PYBIND11_FINDPYTHON=ON
#738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
EZoni
approved these changes
Oct 11, 2024
ax3l
changed the title
setup.py: Hint pybind11 FindPythonLibsNewPYBIND11_FINDPYTHON=ON
ax3l
force-pushed
the
fix-pybind11-python
branch
from
29b5195
to
f967cbe
Compare
EZoni
approved these changes
Oct 11, 2024
|
@ax3l I think you're tracking whether this works or not on your end, so I let you merge or auto-merge. |
ax3l
force-pushed
the
fix-pybind11-python
branch
from
f967cbe
to
f53037d
Compare
ax3l
force-pushed
the
fix-pybind11-python
branch
from
f53037d
to
75f82e3
Compare
Reuse our `find_package(Python ...)` call and use new CMake logic in pybind11. https://pybind11.readthedocs.io/en/stable/compiling.html#modules-with-cmake https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-version-selection Signed-off-by: Axel Huebl <[email protected]>
ax3l
force-pushed
the
fix-pybind11-python
branch
from
75f82e3
to
5b76e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse our
find_package(Python ...)call and use new CMake logic in pybind11.https://pybind11.readthedocs.io/en/stable/compiling.html#modules-with-cmake
https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-version-selection
X-ref: openPMD/openPMD-api#1677 (comment)