allow underscore in client name

DiceDB · Nov 14, 2024 · bc04a30 · bc04a30
1 parent 0a0e1c7
commit bc04a30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/eval/type_string.go b/internal/eval/type_string.go
@@ -21,7 +21,7 @@ func deduceTypeEncoding(v string) (o, e uint8) {
 
 func containsSpacesNewlinesOrSpecialChars(s string) bool {
 	for _, r := range s {
-		if unicode.IsSpace(r) || !unicode.IsLetter(r) && !unicode.IsDigit(r) {
+		if unicode.IsSpace(r) || (!unicode.IsLetter(r) && !unicode.IsDigit(r) && r != '_') {
 			return true
 		}
 	}

diff --git a/internal/eval/type_string_test.go b/internal/eval/type_string_test.go
@@ -1,9 +1,10 @@
 package eval
 
 import (
-	"github.com/dicedb/dice/internal/object"
 	"testing"
 
+	"github.com/dicedb/dice/internal/object"
+
 	"github.com/dicedb/dice/internal/server/utils"
 )
 
@@ -65,11 +66,11 @@ func TestContainsSpacesNewlinesOrSpecialChars(t *testing.T) {
 		{"NoSpecialChars123", false},
 		{"HelloWorld123", false},
 		{"1234567890", false},
+		{"Hello_World", false},
 		{"", false},
 		{"₹₹", true},
 		{"Hello, World!", true},
 		{"Hello\nWorld", true},
-		{"Hello_World", true},
 		{"\tTabbedText", true},
 		{"NormalText!", true},
 	}