-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Refactored and modularized #9
Code Refactored and modularized #9
Conversation
Thanks to @rishavvajpayee a good portion of UI was already created considering what the objective of the PR was. For integrating with API. I am not completely sure about the URL and format if that's ready but I have created the wrapper which should make the later work easy and quick. Let me know if something else needs to be done. |
I have integrated the CLI API. There were 2 issues I observed which I am describing here regarding playground-mono.
|
// This folder will contain or hold constants. For example in this particular file we can store the api endpoints as constants | ||
export const CLI_COMMAND_URL="http://localhost:8080/cli" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better if this derived via config/env var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In fact NextJS has built-in support for that, So we can have .env, .env.development, and so on to handle them.
@N3XT14 please resolve conflicts. |
61f6d80
to
73f665d
Compare
@lucifercr07 . I have resolved the conflicts |
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this btw?
This PR introduces significant refactoring and modularization to enhance code organization and maintainability. Key changes include:
Modularization of CLI Logic:
API Call Integration: