Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code organisation and rendering #58

Conversation

KaviiSuri
Copy link
Contributor

  1. this PR fixes Page crashing due to setState in function component body
  2. this PR improves code organisation by not forcing a hook per page.
  3. Improves rendering performance (https://www.loom.com/share/3e4dec36a56748249938ba7950253d16?sid=cd9c2555-fea2-49d7-b1f3-f8b55c56bcc8) by using components as rendering boundaries.

Note

I would suggest us to move into a direction where we only create separate files for components that are re-used, or if a file gets too big, but still have separate components for separate sections (in the same file). Not doing so means we limit how granularly we can control react re-renders

@lucifercr07 lucifercr07 merged commit 348b267 into DiceDB:master Oct 7, 2024
2 checks passed
prashant67690 added a commit to prashant67690/playground-web that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants