-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#40: Refactor UI search box component #56
base: master
Are you sure you want to change the base?
Conversation
@lucifercr07 can you review and merge this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KaviiSuri this error is not caused by my pr there seems to someone else feature which has caused this you can check the issues tab some one has created this issue too to fix this you can view #54 |
@prashant67690 please resolve the conflicts |
))} | ||
)) | ||
) : ( | ||
<p className="text-lg font-semibold text-gray-500 mb-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we center this vertically?
Got it, its solved on main now, please resolve conflicts |
a785e53
to
214df9b
Compare
@lucifercr07 @KaviiSuri resolved them please check |
Hey @prashant67690 , sorry for the delay, it seems like there are more conflicts, could you please check? Some of the issues might also be already solved on the master branch |
ya sure i will fix the conflicts and push the latest changes tomorrow @KaviiSuri thanks for the reminder |
Closes: #40
Date: 07-10-2024
Completed all the ui fixes and attached the of the final results below for Each Tasks
Screenshots
Task 1
Task 2
Task 3