Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40: Refactor UI search box component #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prashant67690
Copy link

Closes: #40
Date: 07-10-2024

Completed all the ui fixes and attached the of the final results below for Each Tasks

Screenshots

Task 1

Screenshot 2024-10-07 021803

Task 2

Screenshot 2024-10-06 175011

Task 3

Screenshot 2024-10-06 174911

@lucifercr07 lucifercr07 changed the title Fix/UI changes #40: Refactor UI changes Oct 7, 2024
@lucifercr07 lucifercr07 changed the title #40: Refactor UI changes #40: Refactor UI Oct 7, 2024
@lucifercr07 lucifercr07 changed the title #40: Refactor UI #40: Refactor UI search box component Oct 7, 2024
@prashant67690
Copy link
Author

prashant67690 commented Oct 7, 2024

@lucifercr07 can you review and merge this pr

KaviiSuri

This comment was marked as duplicate.

Copy link
Contributor

@KaviiSuri KaviiSuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image i'm getting this error when i test it out. seems like we are stuck in a render loop

@prashant67690
Copy link
Author

prashant67690 commented Oct 7, 2024

@KaviiSuri this error is not caused by my pr there seems to someone else feature which has caused this you can check the issues tab some one has created this issue too to fix this you can view #54

@lucifercr07
Copy link
Contributor

@prashant67690 please resolve the conflicts

))}
))
) : (
<p className="text-lg font-semibold text-gray-500 mb-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we center this vertically?

@KaviiSuri
Copy link
Contributor

@KaviiSuri this error is not caused by my pr there seems to someone else feature which has caused this you can check the issues tab some one has created this issue too to fix this you can view #54

Got it, its solved on main now, please resolve conflicts

@prashant67690
Copy link
Author

@lucifercr07 @KaviiSuri resolved them please check

@KaviiSuri
Copy link
Contributor

Hey @prashant67690 , sorry for the delay, it seems like there are more conflicts, could you please check?

Some of the issues might also be already solved on the master branch

@prashant67690
Copy link
Author

ya sure i will fix the conflicts and push the latest changes tomorrow @KaviiSuri thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX Refactor - 1
3 participants