Cleanup & Adjustment to support static site generation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucifercr07 Can you review this and let me know if something else needs to be done. |
lucifercr07
reviewed
Oct 6, 2024
| @@ -118,6 +118,28 @@ To create a production build: | |||
| npm run build | |||
| ``` | |||
|
|
|||
| ## Creating a Static Production Build | |||
|
|
|||
| To generate a static production build of your Next.js application, follow these steps: | |||
There was a problem hiding this comment.
We'd also need to move export const SHELL_COMMAND_URL = 'http://localhost:8080/shell/exec'; as part of .env for this, otherwise won't be configurable.
KaviiSuri
reviewed
Oct 6, 2024
| import { Clipboard } from 'lucide-react'; | ||
| import { DiceCmdMeta } from '@/data/command'; | ||
|
|
||
| export default function CommandPage({ title, syntax, body, url }: DiceCmdMeta) { |
There was a problem hiding this comment.
this seems unrelated to static site generation, and it breaks the behaviour of "Copied" showing up is that expected?
src/shared/components/Button.tsx
Outdated
| className = '', | ||
| variant = 'default', | ||
| }: ButtonProps) { | ||
| const baseClasses = |
There was a problem hiding this comment.
doesn't seem like this should be inside the function component, would re-define on every render.
lucifercr07
approved these changes
Oct 6, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.