Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: create webservice for api handling #25

Closed
wants to merge 22 commits into from

Conversation

tarun-29
Copy link
Contributor

@tarun-29 tarun-29 commented Oct 2, 2024

Added axios wrapper to handle the api calls so we don't have to write headers ROOT_URL again and again

.env.example Outdated Show resolved Hide resolved
src/shared/constants/apiEndpoints.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@lucifercr07
Copy link
Contributor

@tarun-29 build is failing

@tarun-29
Copy link
Contributor Author

tarun-29 commented Oct 5, 2024

@tarun-29 build is failing

It's done now @lucifercr07

@lucifercr07
Copy link
Contributor

@tarun-29 please cleanup the axios changes and let's just have the ENV changes and readme updates.

@tarun-29
Copy link
Contributor Author

tarun-29 commented Oct 6, 2024

@tarun-29 please cleanup the axios changes and let's just have the ENV changes and readme updates.

Hey @lucifercr07 i am not sure which axios changes you are talking about i already removed everything related to axios can you please attach screenshot where you are able to see

src/lib/api.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not adding/updating any packages this file shouldn't be checked in correct?

@tarun-29 tarun-29 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants