Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #24

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Code cleanup #24

merged 7 commits into from
Oct 2, 2024

Conversation

tarun-29
Copy link
Contributor

@tarun-29 tarun-29 commented Oct 2, 2024

This PR includes following changes

  1. Introduce custom hooks to separate logic and JSX
  2. Code refactoring using ESLint and Prettier
  3. Add prettier package

@lucifercr07
Copy link
Contributor

@tarun-29 please resolve conflicts.

@tarun-29
Copy link
Contributor Author

tarun-29 commented Oct 2, 2024

@tarun-29 please resolve conflicts.

This is resolved

@tarun-29
Copy link
Contributor Author

tarun-29 commented Oct 2, 2024

@lucifercr07 i have removed file which was committed by mistake the build should go through now

@@ -18,6 +18,7 @@
"lucide-react": "^0.446.0",
"next": "14.2.13",
"package.json": "^2.0.1",
"prettier": "^3.3.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this as part of scripts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if you can add this as a Github workflow would be helpful, may be as separate PR this can be taken up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarun-29 please feel free to create new issue and fix this.

@lucifercr07 lucifercr07 merged commit 4da16ab into DiceDB:master Oct 2, 2024
1 check passed
prathameshkoshti pushed a commit to prathameshkoshti/playground-web that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants