Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Refactor - 1 #40

Open
3 tasks
lucifercr07 opened this issue Oct 4, 2024 · 7 comments · May be fixed by #56
Open
3 tasks

UX Refactor - 1 #40

lucifercr07 opened this issue Oct 4, 2024 · 7 comments · May be fixed by #56
Assignees
@prashant67690

Comments

@lucifercr07
Copy link
Contributor

lucifercr07 commented Oct 4, 2024 •
edited
Loading

Changes to be done:

  • Align the icon of DiceDB to the terminal’s left side
  • Add empty state for the search window, so it doesn't look broken when there is no data or searches for something we don't have. (Wording to be decided)
  • The terminal close/minimise/fullscreen icons can be a bit smaller
@prashant67690
Copy link

@lucifercr07 can you assign this to me

@KaviiSuri
Copy link
Contributor

Additional Suggestions

  1. The empty state should say "Try refining your search or browse the documentation for common commands." with a link to docs.
  2. We can also use a suitable icon for the empty state.

@lucifercr07
Copy link
Contributor Author

@prashant67690 assigned, thanks for contributing.

@prashant67690
Copy link

@lucifercr07 can you please specify the changes in the point no 1 , i am attaching a pic here confirm is this icon you are referring , if it is please provide me more details how we want it to be
image

@lucifercr07
Copy link
Contributor Author

@KaviiSuri please confirm once the details around 1st task.

@prashant67690
Copy link

@lucifercr07 @KaviiSuri any updates on the first task details , anyways i have completed the other two task and attaching a sample images here please review it
image
image

@prashant67690 prashant67690 linked a pull request Oct 6, 2024 that will close this issue
Open
@KaviiSuri
Copy link
Contributor

@prashant67690 , the alignment was about aligning the "terminalUI" to the icon, and not the icon to the side of the window , sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashant67690 prashant67690

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#40: Refactor UI search box component prashant67690/playground-web
3 participants
@lucifercr07 @KaviiSuri @prashant67690