Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashio cleanup #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nitram509
Copy link
Contributor

Follow up from PR #6 , where it was recommended to split the PRs.

I hope it is OK, if I also add the .gitignore file here.

"Exception 'java.io.IOException' is never thrown in the method. (⌘F1)
 Inspection info: Reports exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives"

 So it's 100% safe to remove ;)
@PhracturedBlue
Copy link
Contributor

Thank you for splitting this up. What is the purpose of this commit? Why is only the cache function having the throws attribute removed? I think Dfu.fetchFromDevice can throw an exception

@nitram509
Copy link
Contributor Author

the other methods are part of the interface, where a throws declaration is present.
So I kept them.

@nitram509
Copy link
Contributor Author

frankly said, did not much thought about ... just followed IntelliJ IDEA suggestions ;-)
in total not that important to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants