[DO NOT MERGE!] [New feature]: Incorporate Delivery/Livraison bags #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDelsart
changed the title
ThomasDelsart
commented
Nov 4, 2024
| @@ -104,6 +106,15 @@ def _job(self) -> None: | |||
| except TgtgAPIError as err: | |||
| log.error(err) | |||
| items += self._get_favorites() | |||
|
|
|||
| # if state is empty (first scanning iteration), initialize it with the current favorite items | |||
ThomasDelsart
commented
Nov 4, 2024
| @@ -221,3 +224,16 @@ def __getattribute__(self, __name: str) -> Any: | |||
| if _type == "duration": | |||
| return self._get_duration(_mode) | |||
| raise | |||
|
|
|||
| @classmethod | |||
| def delivery_item_conversion(cls): | |||
There was a problem hiding this comment.
Needed because delivery bags have not the same attributes in the API call than Items
ThomasDelsart
commented
Nov 4, 2024
| @@ -86,6 +86,9 @@ def __init__(self, data: dict, location: Union[Location, None] = None, locale: s | |||
| store: dict = data.get("store", {}) | |||
| self.store_name: str = store.get("store_name", "-") | |||
|
|
|||
| self.manufacturer_properties: dict = data.get("manufacturer_properties", {}) | |||
There was a problem hiding this comment.
New attributes for delivery items
ThomasDelsart
commented
Nov 4, 2024
| @@ -135,6 +148,41 @@ def _get_favorites(self) -> list[Item]: | |||
| return [] | |||
| return [Item(item, self.location, self.config.locale) for item in items] | |||
|
|
|||
| def convert_raw_delivery_item(self, raw_delivery_item: dict, mapping: dict) -> Item: | |||
There was a problem hiding this comment.
Conversion of delivery data, not in the same format as item data. Adding some logic to have correct format to build the Item object
ThomasDelsart
commented
Nov 4, 2024
| "element_types_accepted": [ | ||
| "ITEM", # All items/products in delivery | ||
| "HIGHLIGHTED_ITEM", # Item with a special highlight on the top of the delivery pannel | ||
| # "DUO_ITEMS", |
There was a problem hiding this comment.
Not tested yet so still there but commented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Implementation: Delivery Bag Notifications
This PR introduces a feature for receiving notifications related to new Delivery Bags. This is an early implementation, shared to prevent redundant work and foster collaboration. It’s not intended for immediate merging. This has been tested a few scanning runs. It works smoothly but requires more testing before merging. Further discussion is also needed to refine the scope of the feature for this project (CC @Der-Henning )
This PR is a first attempt to solve the following issues:
Resolves #533
Resolves #529
Key Changes
Workflow
Potential Improvements