chore: fix fp in DL3006 & update to newer commit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* spelling: actually Signed-off-by: Josh Soref <[email protected]> * spelling: encountered Signed-off-by: Josh Soref <[email protected]> * spelling: filtered Signed-off-by: Josh Soref <[email protected]> * spelling: github Signed-off-by: Josh Soref <[email protected]> * spelling: gitlab Signed-off-by: Josh Soref <[email protected]> * spelling: library Signed-off-by: Josh Soref <[email protected]> * spelling: modules Signed-off-by: Josh Soref <[email protected]> * spelling: multiple Signed-off-by: Josh Soref <[email protected]> * spelling: official Signed-off-by: Josh Soref <[email protected]> * spelling: omitted Signed-off-by: Josh Soref <[email protected]> * spelling: respect Signed-off-by: Josh Soref <[email protected]> * spelling: shellcheck Signed-off-by: Josh Soref <[email protected]> * spelling: similarly Signed-off-by: Josh Soref <[email protected]> * spelling: variable Signed-off-by: Josh Soref <[email protected]> * spelling: without Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]>
fix: misidentification of pipenv (hadolint#366)
ensure we don't raise if image name is an arg
swarnim-deepsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ensure we don't raise if image name is an arg
How I did it
names can't start with $
How to verify it
added a test, which fails if changes not present