This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
OpenCL: change .bin dir to be in $XDG_DATA_HOME #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YukihoAA
suggested changes
May 2, 2020
| @@ -554,50 +587,11 @@ namespace w2xc | |||
| if (fp == NULL) | |||
| { | |||
| #if !defined(_WIN32) | |||
| if (errno == EACCES || errno == EROFS) | |||
There was a problem hiding this comment.
errno is from L585 so should be moved together.
src/modelHandler_OpenCL.cpp
Outdated
| @@ -411,6 +411,39 @@ namespace w2xc | |||
|
|
|||
| std::string bin_path = std::string(self_path) + "/" + dev_nameStr + ".bin"; | |||
|
|
|||
| #if !defined(_WIN32) | |||
| if (errno == EACCES || errno == EROFS) | |||
There was a problem hiding this comment.
in this case, we don't actually judge we have permission to write self_path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.