Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update #1110

Conversation

blt
Copy link
Collaborator

@blt blt commented Nov 12, 2024

What does this PR do?

Simple cargo update

Copy link
Collaborator Author

blt commented Nov 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blt and the rest of your teammates on Graphite Graphite

@blt blt marked this pull request as ready for review November 12, 2024 02:05
@blt blt requested a review from a team as a code owner November 12, 2024 02:05
@blt blt force-pushed the blt/upgrade_tower_to_0.5_use_workspace_dependency branch from d035c1b to 768ab90 Compare November 12, 2024 02:16
@blt blt mentioned this pull request Nov 12, 2024
Copy link
Contributor

@GeorgeHahn GeorgeHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advise caution pairing a cargo update with the larger hyper update. This is a lot of change to take on at once and it can lead to confounding bugs. I don't think lading will run any issues I'm aware of, but there have been some painful ones lurking here in the past.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/upgrade_tower_to_0.5_use_workspace_dependency branch from 768ab90 to 32aa9ca Compare November 12, 2024 02:24
@blt blt closed this Nov 12, 2024
@blt
Copy link
Collaborator Author

blt commented Nov 12, 2024

I'd advice caution pairing a cargo update with the larger hyper update. This is a lot of change to take on at once and it can lead to confounding bugs. I don't think lading will run any issues I'm aware of, but there have been some painful ones lurking here in the past.

I don't know to what degree I'll actually be able to upgrade hyper. I don't know the crate and its ecosystem well enough to understand the migration documentation and this is a change I don't have a lot of time to devote to. But, I've closed this PR out of an abundance of caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants