Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local] Disable IPv6 and add CONFIG_KEYS to kernel #5

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

zaymat
Copy link

@zaymat zaymat commented Aug 21, 2024

No description provided.

@zaymat zaymat changed the title [local] Enable IPv6 iptables and NAT [local] Disable IPv6 and add CONFIG_KEYS to kernel Aug 28, 2024
@zaymat zaymat force-pushed the mayeul/ipv6-nat branch 2 times, most recently from 44abaf6 to 6a0a9d5 Compare August 28, 2024 16:52
Comment on lines 9 to 18
RUN apt-get update && apt-get install -y \
flex \
bison \
libelf-dev \
xz-utils \
gcc \
make \
patch \
bc \
python3-pip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

package make should have version pinned (...read more)

When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.

View in Datadog  Leave us feedback  Documentation


# Install AWS CLI

RUN pip3 install awscli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Suggested change
RUN pip3 install awscli
RUN pip3 install --no-cache-dir awscli
use --no-cache-dir to avoid caching (...read more)

This rule states that Dockerfiles should not use a cache when installing packages. When building Docker images, Docker has a built-in caching mechanism that reuses instructions from previous builds, which can speed up the build process. However, when installing packages, this can lead to outdated packages being used, which might have security vulnerabilities or bugs.

It is important to avoid using a cache when installing packages because it ensures that the latest version of a package is always used. This reduces the risk of security vulnerabilities and bugs, and ensures that your application has the most up-to-date and secure dependencies.

When installing packages with pip in a Dockerfile, use the --no-cache-dir option. This tells pip not to use a cache when installing packages, which ensures that the latest version of the package is always used. For example, instead of writing RUN pip install django, write RUN pip install --no-cache-dir django.

View in Datadog  Leave us feedback  Documentation

ARG GOLANG_VERSION=1.22.2
ARG TARGETARCH

USER root

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

last user should not be root (...read more)

Do not use root as the last user because your container runs with the root user. Always use a user with lower privileges.

View in Datadog  Leave us feedback  Documentation

Copy link

@chagui chagui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

@zaymat zaymat merged commit 4e8939a into datadog Aug 29, 2024
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants