-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[local] Disable IPv6 and add CONFIG_KEYS to kernel #5
Conversation
c463300
to
c067d6f
Compare
44abaf6
to
6a0a9d5
Compare
tools/packaging/kernel/Dockerfile
Outdated
RUN apt-get update && apt-get install -y \ | ||
flex \ | ||
bison \ | ||
libelf-dev \ | ||
xz-utils \ | ||
gcc \ | ||
make \ | ||
patch \ | ||
bc \ | ||
python3-pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/packaging/kernel/Dockerfile
Outdated
|
||
# Install AWS CLI | ||
|
||
RUN pip3 install awscli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Code Quality Violation
RUN pip3 install awscli | |
RUN pip3 install --no-cache-dir awscli |
use --no-cache-dir to avoid caching (...read more)
This rule states that Dockerfiles should not use a cache when installing packages. When building Docker images, Docker has a built-in caching mechanism that reuses instructions from previous builds, which can speed up the build process. However, when installing packages, this can lead to outdated packages being used, which might have security vulnerabilities or bugs.
It is important to avoid using a cache when installing packages because it ensures that the latest version of a package is always used. This reduces the risk of security vulnerabilities and bugs, and ensures that your application has the most up-to-date and secure dependencies.
When installing packages with pip in a Dockerfile, use the --no-cache-dir
option. This tells pip not to use a cache when installing packages, which ensures that the latest version of the package is always used. For example, instead of writing RUN pip install django
, write RUN pip install --no-cache-dir django
.
tools/packaging/kernel/Dockerfile
Outdated
ARG GOLANG_VERSION=1.22.2 | ||
ARG TARGETARCH | ||
|
||
USER root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6a0a9d5
to
3534f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙇
No description provided.