Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): update envier version pin #8178

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Jan 23, 2024

envier 0.5.1 has the license added correctly, this looks to be the only place it's actually pinned: DataDog/envier#34

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ZStriker19 ZStriker19 requested a review from a team as a code owner January 23, 2024 16:51
@ZStriker19 ZStriker19 requested review from emmettbutler, erikayasuda and P403n1x87 and removed request for emmettbutler and erikayasuda January 23, 2024 16:51
@ZStriker19 ZStriker19 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 23, 2024
@P403n1x87
Copy link
Contributor

I think there are some riot lockfiles that might need to be updated too (see #7935)

@ZStriker19 ZStriker19 requested a review from a team as a code owner January 24, 2024 22:26
@ZStriker19 ZStriker19 enabled auto-merge (squash) January 24, 2024 22:39
@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2024

Benchmarks

Benchmark execution time: 2024-01-24 23:42:21

Comparing candidate commit c224b00 in PR branch zachg/update_envier_version with baseline commit a266617 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 195 metrics, 9 unstable metrics.

@ZStriker19 ZStriker19 merged commit c366e8f into main Jan 25, 2024
122 checks passed
@ZStriker19 ZStriker19 deleted the zachg/update_envier_version branch January 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants