Add support for Span Events #200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Signed-off-by: Marco Costa <[email protected]>
marcotc
force-pushed
the
marcotc/add_agent_span_events_support
branch
from
e2e8837
to
c96f2d3
Compare
Comment on lines
+483
to
+486
| if "span_events" in span: | ||
| for event in span["span_events"]: | ||
| if "attributes" in event: | ||
| event["attributes"].pop(key[23:], None) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
Comment on lines
+377
to
+388
| if diff_key not in d_exp: | ||
| raise AssertionError( | ||
| f"Span event {diff_type} value '{diff_key}' in received span event but is not in the expected span event." | ||
| ) | ||
| elif diff_key not in d_rec: | ||
| raise AssertionError( | ||
| f"Span event {diff_type} value '{diff_key}' in expected span event but is not in the received span event." | ||
| ) | ||
| else: | ||
| raise AssertionError( | ||
| f"Span event {diff_type} mismatch on '{diff_key}': got '{d_rec[diff_key]}' which does not match expected '{d_exp[diff_key]}'." | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the top-level Span field "span_events" in the agent.
Currently waiting for the real agent changes, to ensure the behaviors match.