Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only-one-copy-in-graph-per-cluster #286

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Nov 13, 2024

Only keeping the last version of an ingested cluster. The previous versions are deleted (graph and mongo data).

@jt-dd jt-dd marked this pull request as ready for review November 13, 2024 22:17
@jt-dd jt-dd requested a review from a team as a code owner November 13, 2024 22:17
Copy link
Contributor

@edznux-dd edznux-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the Clean function called, I see the interface and its implementation defined but never called?

Are you expecting to do that somewhere else?

@@ -145,3 +145,29 @@ func (jgp *JanusGraphProvider) Close(ctx context.Context) error {

return nil
}

// Raw returns a handle to the underlying provider to allow implementation specific operations e.g graph queries.
func (jgp *JanusGraphProvider) Clean(ctx context.Context, cluster string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for later: it would be great to have a trace for this. I have no intuition on how long it takes.

@jt-dd jt-dd merged commit 724c53f into main Nov 14, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/only-one-copy-in-graph-per-cluster branch November 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants