Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mtl h dgpu #548

Open
wants to merge 53 commits into
base: dasharo
Choose a base branch
from
Open

Mtl h dgpu #548

wants to merge 53 commits into from

Conversation

mkopec
Copy link
Member

@mkopec mkopec commented Aug 12, 2024

No description provided.

@mkopec mkopec force-pushed the mtl-h-dgpu branch 3 times, most recently from 957e2cc to 230d603 Compare August 20, 2024 10:22
@miczyg1
Copy link
Contributor

miczyg1 commented Sep 11, 2024

@mkopec something wrong happened, because the PR contains changes from iGPU variant

@mkopec mkopec force-pushed the mtl-h-dgpu branch 2 times, most recently from 152f8d9 to ba88689 Compare September 11, 2024 14:02
@mkopec
Copy link
Member Author

mkopec commented Sep 11, 2024

@miczyg1 rebased, should be okay now

miczyg1
miczyg1 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how useful these comments will be. Without a spec it is hard to say what should be done and how. There is a lot of other things in original firmware ACPI. Leaving it a sa comment rather than change request,

src/mainboard/clevo/mtl-h/acpi/dgpu/gps.asl Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/gps.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/gps.asl Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/gpu_top.asl Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvop.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvjt.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvjt.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvpcf.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvpcf.asl Outdated Show resolved Hide resolved
src/mainboard/clevo/mtl-h/acpi/dgpu/nvpcf.asl Outdated Show resolved Hide resolved
Base automatically changed from mtl-h to dasharo October 1, 2024 10:39
@mkopec mkopec force-pushed the mtl-h-dgpu branch 2 times, most recently from 95c1c65 to 77e62c0 Compare November 12, 2024 14:50
miczyg1
miczyg1 requested changes Nov 13, 2024
View reviewed changes
.github/workflows/build.yml Outdated
@@ -11,37 +11,16 @@ on:
- '*'

jobs:
build_novacustom_ec:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkopec I think we can still build EC regardless if EC sync is used or not. The "Obtain EC" step is removed and the dependency too, so it should be fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, commit amended: c2b1573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeataZdunczyk BeataZdunczyk BeataZdunczyk left review comments

@miczyg1 miczyg1 miczyg1 requested changes

@krystian-hebel krystian-hebel Awaiting requested review from krystian-hebel

@SergiiDmytruk SergiiDmytruk Awaiting requested review from SergiiDmytruk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkopec @miczyg1 @BeataZdunczyk @crawfxrd @philipandag