Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions in trigger schema & small cleanup #154

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ArturSztuc
Copy link
Contributor

@ArturSztuc ArturSztuc commented Nov 7, 2024

This PR goes together with:

  1. Removing HSIpassthrough & reorganisation of bitword variable setup trigger#361
  2. Removing obsolete trigger configs & new default for TCDataProcessor::td_readout_limit daqsystemtest#154

Changes:

  1. Added descriptions to the trigger schemas
  2. Removed few that are obsolete/not used attributes/objects
    • This includes HSI passthrough. It was already removed in v4, and somehow it was not removed in v5. This included removal of the hsi-passthrough code in the trigger repository (see the trigger PR above)
  3. Changed the default value for TCDataProcessor::td_readout_limit from 100 to 1,000,000: it used to be in terms of milliseconds, now it is in terms of ticks.

Tested by running integration tests (all pass), and the example test configuration.

Copy link
Contributor

@glehmannmiotto glehmannmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArturSztuc ArturSztuc merged commit 3914d28 into develop Nov 11, 2024
2 checks passed
@ArturSztuc ArturSztuc deleted the asztuc/triggerschema_descriptions branch November 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants