Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akmenu Streaming Audio #1043

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chyyran
Copy link
Contributor

@chyyran chyyran commented May 24, 2020

What's changed?

Tell us what you've changed.

Where have you tested it?

Tell us where have you tested it.


Pull Request status

  • This PR has been tested using the provided devkitPro, devkitARM, and EasyGL2D.

@chyyran
Copy link
Contributor Author

chyyran commented Jun 3, 2020

This currently freezes for unknown reasons after some time has passed. There seems to be a bug in the buffering routine, or some other issue that causes it to freeze. Need to try buffering with smaller buffers, or using some other buffering approach.

@chyyran chyyran force-pushed the feature-akmenu-streaming-audio-redux branch from ddc887f to b16cb1c Compare June 12, 2020 15:21
@chyyran
Copy link
Contributor Author

chyyran commented Jun 22, 2020

Leaving a note here just in case, likely culprit is some buffer overrun overwriting fifoSendQueue in akmenu. Fix is to properly write a looping stream for the FILE abstraction, and to handle out of bounds writes for buffer.

@ObscureExtractor
Copy link

I'm kinda new to GitHub, so if this comment breaks the rules or anything, you can gladly take it down. But I was wondering what the Classic music in the TwilightMenu is called. This might be straying away from this main request but, I just really want to know what this song is called. It's so catchy.

@NightScript370
Copy link
Member

Hello there @ObscureExtractor. We recommend for the future that you take these questions to the Discord server instead. It does not pertain to this Pull Request
There is a video that shows all the songs: https://youtu.be/_B-50pwDT0k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants