-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation, switch to pyproject.toml
and ruff
#365
Conversation
pyproject.toml
and ruff
pyproject.toml
and ruff
pyproject.toml
and ruff
Looks great! It's much better now! |
The build is somehow broken now, but related to setuptools I think. |
It seems like enjoy is broken for PandaReach. I'm taking a look |
The problem comes from |
I found the issue, it is a mix of DLR-RM/rl-trained-agents#10 and DLR-RM/stable-baselines3@12e9917 (where the observation space was set to the env one), I will push a fix for the VecNormalize stats. |
Description
Add proper documentation because the README was a mess.
Also do the same as in DLR-RM/stable-baselines3#1361
Can be see here: https://rl-baselines3-zoo.readthedocs.io/en/feat-doc/index.html
@qgallouedec in case you can do a quick review that's nice, otherwise I'll merge it without as this is important to provide clearer doc.
You don't need to go though all files, there are too many changes.
Motivation and Context
See #299
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line