Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation, switch to pyproject.toml and ruff #365

Merged
merged 11 commits into from
Mar 12, 2023
Merged

Conversation

araffin
Copy link
Member

@araffin araffin commented Mar 11, 2023

Description

Add proper documentation because the README was a mess.

Also do the same as in DLR-RM/stable-baselines3#1361

Can be see here: https://rl-baselines3-zoo.readthedocs.io/en/feat-doc/index.html

@qgallouedec in case you can do a quick review that's nice, otherwise I'll merge it without as this is important to provide clearer doc.

You don't need to go though all files, there are too many changes.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

See #299

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin changed the title Add Documentation Add Documentation, switch to pyproject.toml and ruff Mar 11, 2023
@araffin araffin changed the title Add Documentation, switch to pyproject.toml and ruff Add documentation, switch to pyproject.toml and ruff Mar 11, 2023
@qgallouedec
Copy link
Collaborator

Looks great! It's much better now!
I didn't go through all the files since it's unlikely to break anything.

qgallouedec
qgallouedec previously approved these changes Mar 11, 2023
@araffin
Copy link
Member Author

araffin commented Mar 11, 2023

I didn't go through all the files since it's unlikely to break anything.

The build is somehow broken now, but related to setuptools I think.

@qgallouedec
Copy link
Collaborator

It seems like enjoy is broken for PandaReach. I'm taking a look

@araffin
Copy link
Member Author

araffin commented Mar 12, 2023

It seems like enjoy is broken for PandaReach. I'm taking a look

The problem comes from VecNormalize which overrides somehow the observation space. Will see if I can push a fix soon.

@araffin
Copy link
Member Author

araffin commented Mar 12, 2023

I found the issue, it is a mix of DLR-RM/rl-trained-agents#10 and DLR-RM/stable-baselines3@12e9917 (where the observation space was set to the env one), I will push a fix for the VecNormalize stats.

@araffin araffin merged commit 10de3a8 into master Mar 12, 2023
@araffin araffin deleted the feat/doc branch March 12, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants