Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix itk2vol (issue #390) #393

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Fix itk2vol (issue #390) #393

merged 7 commits into from
Apr 7, 2021

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Apr 2, 2021 •
edited
Loading

PR Description

Fix issue of compilation (issue #390) and cmake use (this fix all ITK read/write that was failing).
(for travis check, first merging [PR #394 ]

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

@phcerdan
Copy link
Member

phcerdan commented Apr 6, 2021

Looks good to me, the travis-ci error seems unrelated.

@phcerdan phcerdan self-requested a review April 6, 2021 14:06
@kerautret
Copy link
Member Author

Looks good to me, the travis-ci error seems unrelated.

Thanks, yes trying to reload (now a timeout appears 😱

@kerautret kerautret merged commit dda16f1 into DGtal-team:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phcerdan phcerdan phcerdan approved these changes

Assignees
No one assigned
Labels
Ready For Reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @phcerdan