-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organize tests #890
Merged
Merged
organize tests #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/organize-tests
branch
4 times, most recently
from
October 16, 2024 14:31
28b8ca9
to
717de2f
Compare
NoahSaso
force-pushed
the
noah/organize-tests
branch
from
October 16, 2024 14:32
717de2f
to
d13956f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #890 +/- ##
===============================================
- Coverage 96.67% 96.64% -0.04%
===============================================
Files 241 241
Lines 65989 65122 -867
===============================================
- Hits 63798 62938 -860
+ Misses 2191 2184 -7 ☔ View full report in Codecov by Sentry. |
NoahSaso
force-pushed
the
noah/organize-tests
branch
from
October 17, 2024 04:33
28c2072
to
30b04b0
Compare
JakeHartnell
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
NoahSaso
added a commit
that referenced
this pull request
Oct 31, 2024
* moved all contract wrappers to dao-testing * updated schema * added DAO creation testing suite scaffold * made DAO testing suites for all voting modules * rewrote dao-rewards-distributor tests using dao-testing suite * fixed integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this organizes tests a bit more and prepares a suite to help create DAOs. it could be improved, but it is good enough for now to use for #888, and it will be improved further as it is used in creating a new set of tests.