Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize tests #890

Merged
merged 6 commits into from
Oct 17, 2024
Merged

organize tests #890

merged 6 commits into from
Oct 17, 2024

Conversation

NoahSaso
Copy link
Member

@NoahSaso NoahSaso commented Oct 15, 2024

this organizes tests a bit more and prepares a suite to help create DAOs. it could be improved, but it is good enough for now to use for #888, and it will be improved further as it is used in creating a new set of tests.

  • moved all contract wrappers to dao-testing
  • created a dao-testing suite that helps quickly create DAOs with any of the various voting modules
  • rewrote dao-rewards-distributor tests to use dao-testing suite as a proof of concept

@NoahSaso NoahSaso force-pushed the noah/organize-tests branch 4 times, most recently from 28b8ca9 to 717de2f Compare October 16, 2024 14:31
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 99.67015% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.64%. Comparing base (b0c7ef1) to head (9112c09).

Files with missing lines Patch % Lines
...l/dao-proposal-multiple/src/testing/instantiate.rs 76.19% 5 Missing ⚠️
contracts/external/cw-token-swap/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #890      +/-   ##
===============================================
- Coverage        96.67%   96.64%   -0.04%     
===============================================
  Files              241      241              
  Lines            65989    65122     -867     
===============================================
- Hits             63798    62938     -860     
+ Misses            2191     2184       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoahSaso NoahSaso marked this pull request as ready for review October 17, 2024 04:35
Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@NoahSaso NoahSaso merged commit c05a6c8 into development Oct 17, 2024
6 of 7 checks passed
@NoahSaso NoahSaso deleted the noah/organize-tests branch October 17, 2024 14:13
NoahSaso added a commit that referenced this pull request Oct 31, 2024
* moved all contract wrappers to dao-testing

* updated schema

* added DAO creation testing suite scaffold

* made DAO testing suites for all voting modules

* rewrote dao-rewards-distributor tests using dao-testing suite

* fixed integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants