Fix fake bridge configuration option ovs_bridge
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue CumulusNetworks#313 where the ovs_bridge parameter for fake bridges was not applied. This fix is backward compatible to the workaround where the parent bridge name is repeated at the beginning of the ovs_options parameter.
lachbaer
force-pushed
the
ovs_parent_fix
branch
from
567585a
to
d4ac2a6
Compare
|
In the first PR commit there was a breaking change for existing configurations that use the workaround as mentioned in #313. This has been fixed in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #313 where the ovs_bridge parameter for fake bridges was not applied.
This fix has been tested locally.