Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8767 update payload attributes #8824

Merged
merged 21 commits into from
Nov 15, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Nov 6, 2024

PR Description

Use the new TARGET_BLOBS_PER_BLOCK_ELECTRA and MAX_BLOBS_PER_BLOCK_ELECTRA params in the PayloadBuildingAttributes.

let the new param be unchanged so that reference tests do not fail

Fixed Issue(s)

addresses all changes required by #8767, the only remaining thing is changing the actual values when they will be changed on spec
In particular this PR is related to:
ethereum/execution-apis#574
ethereum/consensus-specs#3800

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi force-pushed the 8767-update-payload-attributes branch 2 times, most recently from f8ee637 to 83f14de Compare November 6, 2024 16:15
@mehdi-aouadi mehdi-aouadi marked this pull request as draft November 6, 2024 18:06
@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review November 6, 2024 18:31
@mehdi-aouadi mehdi-aouadi self-assigned this Nov 6, 2024
@mehdi-aouadi mehdi-aouadi removed the request for review from tbenr November 6, 2024 19:01
@mehdi-aouadi mehdi-aouadi marked this pull request as draft November 6, 2024 19:01
@tbenr tbenr force-pushed the 8767-update-payload-attributes branch from 0ca5247 to 1c218a9 Compare November 12, 2024 15:48
@tbenr tbenr force-pushed the 8767-update-payload-attributes branch from 1c218a9 to fbf45ae Compare November 14, 2024 16:14
@tbenr tbenr marked this pull request as ready for review November 15, 2024 10:46
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits, but I don't understand which spec update is implemented. The one linked doesn't have TARGET parameter and is tied with EIP7594 rather than ELECTRA

@tbenr
Copy link
Contributor

tbenr commented Nov 15, 2024

LGTM, just a few nits, but I don't understand which spec update is implemented. The one linked doesn't have TARGET parameter and is tied with EIP7594 rather than ELECTRA

Per my understanding peerDas will use a similar approach (via EIP7594 postfix) but we will do a similar thing for ELECTRA too (this PR is anticipating it essentially)

@tbenr tbenr enabled auto-merge (squash) November 15, 2024 17:55
@tbenr tbenr merged commit b28ac65 into Consensys:master Nov 15, 2024
16 of 17 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8767-update-payload-attributes branch November 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants