ENH: set data keys as first positional arguments #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positional arguments of the internal
function
of aParametrizedBackendFunction
are now ordered: args for theparameters
come after args for the data sample over which the__call__()
is evaluated. This is done so that one can compute the gradient of the backend function, e.g. withjax.jacfwd()
:We used
Partial
integrate the data columns into the function. It may be possible to integrate that into thegradient_creator()
in order to address e.g. #442.