-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: implement BreitWigner
expression classes
#423
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@mmikhasenko have a look at this preview. I followed your Breit–Wigner implementation, but don't get why the numerator is 1, i.e. It seems better to me to make the lineshape unitless. With the current definition, I have to redefine AmpForm's Am I missing something here? Seeing as this is considered the default implementation for |
I'm also not sure about the definition of the energy-dependent width of the channels in a It results in a weird 'Flatté' lineshape when simplifying: import sympy as sp
from ampform.dynamics import ChannelArguments, MultichannelBreitWigner
channels = [ChannelArguments(sp.Symbol(f"Gamma{i}")) for i in [1, 2]]
MultichannelBreitWigner(s, m0, channels).doit().simplify() |
Probably best to 'standardize' the symbolic Breit–Wigner as One can then customize the parametrization of There is a problem though when numerator is decoupled from denominator (production). There, you may want to absorb |
As for #423 (comment), see RUB-EP1/amplitude-serialization#31. Using This does not work in a multi-channel Breit–Wigner because the normalization factor |
I love your pages, Remco. The constant terms in BW is denoted G, not gsq. It is exactly how I defined it for HS3 document, but later I thought that gsq is still better because users assume that the constant 'width' corresponds to the observed width. It's not the case, in the current approach. That is why I fell back to 'gsq' |
Closes #438