Allow setting docker_host and log_driver
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow for more flexibility in the configuration of the container
sdclarke
force-pushed
the
scott/docker-host
branch
from
9ffe649
to
c9ce7e8
Compare
|
I realised the default settings for the log driver could unexpectedly clobber whatever was set at the daemon level if people chose to configure it that way, so I've replaced the defaults with an empty string and dictionary, which will default to whatever the daemon is configured to do. |
abderrahim
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for more flexibility in the configuration of the container
For example it is possible to give the path of a
podmansocket in place of adockersocket.It is also possible to switch to a different log-driver which handles log rotation.