Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize quest database searching redux #114

Merged
merged 2 commits into from
May 23, 2024
Merged

Optimize quest database searching redux #114

merged 2 commits into from
May 23, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • Add loading icon. (using the same texture as refresh)
  • Buffering "addPanel()" on quest database to optimize search. (addPanel is too slow...)

difference from #108:

  • removes whitespace changes
  • uses a unique key

supersedes #108

@WaitingIdly WaitingIdly added the enhancement New feature or request label May 16, 2024
@WaitingIdly WaitingIdly changed the title Optimize quest database searching Optimize quest database searching redux May 17, 2024
@Rongmario Rongmario merged commit f5960d5 into CleanroomMC:1.12 May 23, 2024
1 of 2 checks passed
@Rongmario Rongmario mentioned this pull request May 23, 2024
Closed
@WaitingIdly WaitingIdly deleted the optimize-search branch May 23, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rongmario Rongmario Rongmario approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WaitingIdly @Rongmario @KatatsumuriPan