Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random quest ID #110

Closed

Conversation

KatatsumuriPan
Copy link

Now newly created quest ID will be random.
This prevents merge conflicts when multiple people try to add or remove quests simultaneously.

Changing the type of quest ID from int to UUID is pending for compatibility.

I won't apply this change to quest-line ID and other IDs until #103 is merged.

Copy link
Collaborator

@WaitingIdly WaitingIdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problems:

  • similar logic should also apply to questlines
  • since the questID is absurdly long now, should change PanelButtonQuest.java:103 to not display the questID, regardless of if advancedInfo is enabled
  • again, absurdly long so it should be less publicly visible, should change EventHandler.java:142 so sharing the quest to chat doesnt include the questID.
  • really long, want an easy way to copy - GuiQuestLines.java:354 is the place where we get the popup for "Share to Chat", should add an option below that for "Copy ID" which copies the quest ID to the clipboard

question:
what is the logic that leads to continuing to use an int instead of switching to using a UUID, as was done in GTNewHorizons#89?

@KatatsumuriPan
Copy link
Author

problems:

  • similar logic should also apply to questlines

I won't apply this change to quest-line ID and other IDs until #103 is merged.

question:
what is the logic that leads to continuing to use an int instead of switching to using a UUID, as was done in GTNewHorizons#89?

I think the only advantage of UUID is their randomness.
Considering the cost and trouble, I don't think there is any benefit to changing to UUID.

@Rongmario
Copy link
Member

Closing in favour of #113. Thank you for all the work!

@Rongmario Rongmario closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants