Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum updates #4

Merged
merged 12 commits into from
Jul 28, 2024
Merged

Ethereum updates #4

merged 12 commits into from
Jul 28, 2024

Conversation

welldan97
Copy link
Collaborator

Ethereum:

  • Fix all assets withdrawal
  • Fix getTxHistory - now it returns Txs for specific delegators, not just all Txs
  • Define & explain fee calculation
  • Validate amounts and explain their format in the docs, since it is different from the main libs
  • Add viem & ethers examples
  • Minor code & docs improvements

All networks:

  • Better lib compatibility notice in docs

mkaczanowski
mkaczanowski approved these changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@mkaczanowski mkaczanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkaczanowski mkaczanowski merged commit 6842387 into main Jul 28, 2024
3 checks passed
@welldan97 welldan97 deleted the ethereum-updates branch July 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaczanowski mkaczanowski mkaczanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@welldan97 @mkaczanowski