Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pagination #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: pagination #1

wants to merge 2 commits into from

Conversation

fmorency
Copy link

@fmorency fmorency commented Oct 2, 2024 •
edited
Loading

Support page and page_size URL parameters on all endpoints.

The underlying DB access is NOT optimized.

@chalabi2
Copy link
Member

chalabi2 commented Oct 3, 2024

can you expand on what you mean by

The underlying DB access is NOT optimized.

@fmorency
Copy link
Author

fmorency commented Oct 3, 2024

can you expand on what you mean by

The underlying DB access is NOT optimized.

We're not fetching pages from the DB. The query to the DB is still the same as before. We're simply filtering the result to return pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmorency @chalabi2