Update the Utxo schema to be an object #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how the hydra project (and cardano-api) is encoding a UTxO.
ch1bo
changed the title
KtorZ
reviewed
Aug 8, 2023
| ] | ||
| , "type": "object" | ||
| , "propertyNames": | ||
| { "pattern": "^[0-9a-f]{64}#[0-9]+$" } |
There was a problem hiding this comment.
This kind of key encoding multiple information at once has shown to be quite difficult to parse for clients down the line so that is something I've been trying to avoid in the schema.
There was a problem hiding this comment.
Also, if changed here, it should be changed consistently across all occurrences of TransactionOutputReference which then becomes a little awkward.
KtorZ
reviewed
Aug 8, 2023
| @@ -1881,17 +1881,16 @@ | |||
|
|
|||
| , "Utxo": | |||
There was a problem hiding this comment.
As a side-note, this definition should probably not even be here. This is not used anywhere in the Cardano schema actually. It is used in a few places in Ogmios but that's not so-to-speak needed to capture Cardano's on entities (as weird as it may sound).
KtorZ
force-pushed
the
main
branch
12 times, most recently
from
18b04c2
to
cf11243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the hydra project (and cardano-api) is encoding a UTxO.
As this is not currently used by
cardano.jsonschema itself, I wondered we could update this easily and we can just refer to this schema from within hydra (as we already do with protocol parameters)?