Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of kineticsSpeciesIndex in diamond_cvd examples #1814

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

speth
Copy link
Member

@speth speth commented Nov 16, 2024

Fixes #1806

Changes proposed in this pull request

  • Fix incorrect arguments to kineticsSpeciesIndex in both the Python and Matlab versions of the diamond_cvd example

If applicable, fill in the issue number this pull request is fixing

Closes #1806

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the Examples label Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (70521b7) to head (de03728).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         383      383           
  Lines       54620    54620           
  Branches     9099     9099           
=======================================
+ Hits        40016    40019    +3     
+ Misses      11601    11599    -2     
+ Partials     3003     3002    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth!

@ischoegl ischoegl merged commit f3d77f4 into Cantera:main Nov 16, 2024
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diamond CVD example produces incorrect growth rate
2 participants