-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update / Add High pressure transport #1704
Open
wandadars
wants to merge
37
commits into
Cantera:main
Choose a base branch
from
wandadars:high_pressure_transport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
157e62b
initial work on transport updates
wandadars c47b1c2
changed high pressure transport to mixture averaged and added new Chu…
wandadars d6d60fe
added a test, and fixed names for transport objects
wandadars fff6bd4
working Chung method, bug fixes in Lucas method
wandadars d0a5e51
improvements to docstrings and comments
wandadars 890fe1a
documentation updates
wandadars ef12226
more documentation added
wandadars bc2b998
more documentation
wandadars 6ef4429
more documentation & reverted Takahashi method to original approach
wandadars d4274a2
[Doc] Add LaTeX macro file for Doxygen
speth 74bb0d8
first pass at review edits
wandadars 64d830a
more documentation updates
wandadars d05b7c6
more documentation updates
wandadars 913814b
addressing comments, new sample added
wandadars f18aaa3
updates for documentation of the Ely and Hanley conductivity implemen…
wandadars 06d878e
more work on documenting the Ely and Hanley method
wandadars e87f571
final updates for ely and hanley method
wandadars e6451c3
detailed model description added for ely and hanley thermal conductivity
wandadars b0a5768
wrapped doxygen comment for thermal conductivity to 88 characters
wandadars a0e94e1
[transport] fixed incorrect equation in binary diffusion coefficient …
wandadars 6df98a4
[transport] removed mixture quantity structs and placed values as pri…
wandadars 8c08115
[transport] changed the chung name to high-pressure-Chung
wandadars 516cf14
[transport] added coding to get acentric factor from critical-propert…
wandadars 3013fdb
[transport] added new unit test, updated example, removed old unit te…
wandadars 3b5082e
[transport] fixed bug in debye to SI conversion, minor formatting tweaks
wandadars 254a6e5
[transport] minor comment adjustments
wandadars a21c5f8
[transport] limited ely/hanley methane correlation to 10,000 Kelvin
wandadars ea15a8b
[transport] change broken high-pressure test to use RK eos instead of…
wandadars e7bb98f
[transport] cleaned up ely and hanley conduction, cleaned up docs on …
wandadars 504bfd1
[transport] prevent species that have a=0, b=0 from being used in the…
wandadars d2395a9
[transport] added new unit test and fixed some issues with unit test …
wandadars 58c8b23
[transport] fixed whitespace issues
wandadars d0e2f75
[transport] fixed unit test failure for transport_models_test, added …
wandadars 666ed9e
[transport] updated docs on high pressure transport models
wandadars 8c4f858
[transport] added regression-type test for high pressure transport mo…
wandadars 29cbbc6
[transport] fixing formatting & removing unused files
wandadars c4a16cc
[transport] converted list to numpy array in sample
wandadars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
% Macros defined here should also be defined in Sphinx conf.py | ||
\newcommand{\t}[1]{\mathrm{#1}} | ||
\newcommand{\pxpy}[2]{\frac{\partial #1}{\partial #2}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.