Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of 'ReactorEdge' class #1697

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gkogekar
Copy link
Member

@gkogekar gkogekar commented May 23, 2024

Changes proposed in this pull request

  • Implementation of the 'ReactorEdge' class for modeling edges in the reactor
  • Modification to the reactor governing equations to include production rates due to edges
  • A simple example demonstrating the usage of 'ReactorEdge' class.

If applicable, fill in the issue number this pull request is fixing

Closes Cantera/enhancements#203

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 5.49451% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 75.59%. Comparing base (d37a76b) to head (1b5cb69).

Files Patch % Lines
src/zeroD/ReactorEdge.cpp 0.00% 30 Missing ⚠️
src/clib/ctreactor.cpp 0.00% 29 Missing ⚠️
interfaces/cython/cantera/reactor.pyx 19.04% 17 Missing ⚠️
src/zeroD/ReactorBase.cpp 0.00% 6 Missing ⚠️
include/cantera/zeroD/ReactorBase.h 0.00% 2 Missing ⚠️
include/cantera/zeroD/ReactorEdge.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   75.69%   75.59%   -0.11%     
==========================================
  Files         443      445       +2     
  Lines       60975    61066      +91     
  Branches     9551     9554       +3     
==========================================
+ Hits        46158    46163       +5     
- Misses      11786    11872      +86     
  Partials     3031     3031              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischoegl
Copy link
Member

ischoegl commented Oct 5, 2024

Linking to a recent comment Cantera/enhancements#201 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 'ReactorEdge' class in the reactor code to model edge interactions
2 participants