Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Tests for Kinetics Class for the Matlab Toolbox #1665

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ssun30
Copy link
Contributor

@ssun30 ssun30 commented Jan 23, 2024

Changes proposed in this pull request

  • Added Kinetics class tests for all methods and properties currently implemented

If applicable, fill in the issue number this pull request is fixing

Updates to Cantera/enhancements#177

If applicable, provide an example illustrating new features this pull request is introducing

Added tests for rates of progress, rate constants, species rates, and thermodynamic values.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
Copy link
Member

@ssun30 and @rwest ... what are the current plans on this PR and Cantera/enhancements#177? With the old MATLAB toolbox removed, the next Cantera version will only provide for the experimental toolbox.

@ssun30
Copy link
Contributor Author

ssun30 commented Jun 22, 2024

@ssun30 and @rwest ... what are the current plans on this PR and Cantera/enhancements#177? With the old MATLAB toolbox removed, the next Cantera version will only provide for the experimental toolbox.

Hi Ingmar, finishing the test suite is back on our to-do list and we were aiming to complete it by the end of the month. There is a slight delay so maybe the first week of July we shall have all the unit tests ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants