Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 liquid pool #1639

Draft
wants to merge 6 commits into
base: 3.0
Choose a base branch
from
Draft

3.0 liquid pool #1639

wants to merge 6 commits into from

Conversation

LJ1356
Copy link

@LJ1356 LJ1356 commented Oct 24, 2023

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
Copy link
Member

Thanks for the pull request! Could you please modify this PR so it targets the main branch of the repository? Thank you!

@speth
Copy link
Member

speth commented Oct 25, 2023

Thanks for starting this pull request, @LJ1356. In addition to @ischoegl's suggestion, can you please describe the feature this PR is implementing in the summary? Do you have a document or any references you can share that describe the model that is implemented here?

@ischoegl ischoegl mentioned this pull request Oct 26, 2023
5 tasks
@LJ1356
Copy link
Author

LJ1356 commented Oct 26, 2023

I apologized for the pull request. It is my first time to code with git and github. I did not realized when I made this PR.

I folked Cantera to my own repo and I just planed to test on my own repo because these codes is still in development.

I developed it for counterflow flame with liquid pool boundary condition at beginning of this year based on Cantera 3.0.0. I am not pretty sure if it still work when I change PR to main branch. I may need some time to make it compatible with main branch.

@speth
Copy link
Member

speth commented Oct 26, 2023

No need to apologize! I think this is a feature that would be worth integrating into Cantera, once you're further along in the development. Please feel free to leave this PR open, but convert it to a "draft" PR -- there should be a link on the right side of the page that does this. That way, people will be aware that you're working on this, but will know that it isn't ready for an in-depth review yet.

@LJ1356 LJ1356 marked this pull request as draft October 26, 2023 15:59
@LJ1356
Copy link
Author

LJ1356 commented Oct 26, 2023

Hi speth, I appreciate for your suggestions. I have converted it to draft. After I finished development, I will request pull to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants