Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Update electrochemical reaction type input for BV and Marcus kinetics #1416

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

WIP - Update electrochemical reaction type input for BV and Marcus kinetics #1416

wants to merge 4 commits into from

Commits on Dec 9, 2022

  1. WIP adding Marcus theory echem kinetics formulation

    @korffdm
    korffdm committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a4e9837 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. WIP updated Marcus correction term to use chemPotentials 

    The marcus correction term was using deltaGibbs0_RT and it now uses
deltaGibbs_RT calculated using chemPotentials instead of
standardChemPotentials. This was done to address asymmetry when generating
a Tafel plot of the current Marcus kinetics implementation.
    @korffdm
    korffdm committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    56df7b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. WIP cleaned up unnecessary elements of source code for implementation 

    Implementation of Marcus theory into the voltageCorrection of
InterfaceRate.h produces symmetric Tafel plot for Marcus kinetics.
    @korffdm
    korffdm committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ddb5d47 View commit details
    Browse the repository at this point in the history

  2. WIP added documentation for Marcus kinetics and streamlined BV, Marcus

    @korffdm
    korffdm committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    2ab340d View commit details
    Browse the repository at this point in the history