Minor updates

- Add todo item for deprecation of Arrhenius2 constructor - Add missing override declarations in BlowersMaselRate
Cantera · Feb 6, 2022 · f85d54f · f85d54f
1 parent dd11605
commit f85d54f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/include/cantera/kinetics/Arrhenius.h b/include/cantera/kinetics/Arrhenius.h
@@ -364,7 +364,7 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
      */
     BlowersMaselRate(double A, double b, double Ea0, double w);
 
-    unique_ptr<MultiRateBase> newMultiRate() const {
+    unique_ptr<MultiRateBase> newMultiRate() const override {
         return unique_ptr<MultiRateBase>(
             new MultiRate<BlowersMaselRate, BlowersMaselData>);
     }
@@ -377,7 +377,7 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
     }
 
     //! Identifier of reaction rate type
-    virtual const std::string type() const {
+    virtual const std::string type() const override {
         return "Blowers-Masel";
     }
 
@@ -386,9 +386,10 @@ class BlowersMaselRate final : public ArrheniusBase, public ReactionRate
      *  @param node  AnyMap containing rate information
      *  @param rate_units  Unit definitions specific to rate information
      */
-    virtual void setParameters(const AnyMap& node, const UnitStack& rate_units);
+    virtual void setParameters(
+        const AnyMap& node, const UnitStack& rate_units) override;
 
-    virtual void getParameters(AnyMap& node) const;
+    virtual void getParameters(AnyMap& node) const override;
 
     void check(const std::string& equation, const AnyMap& node) override {
         checkRate(equation, node);

diff --git a/include/cantera/kinetics/RxnRates.h b/include/cantera/kinetics/RxnRates.h
@@ -48,6 +48,9 @@ class Arrhenius2 : public ArrheniusBase
     ///     order and the dimensionality (surface or bulk).
     /// @param b Temperature exponent. Non-dimensional.
     /// @param E Activation energy in temperature units. Kelvin.
+    ///
+    /// @todo  Add deprecation warning pointing out change of activation
+    ///     energy units.
     Arrhenius2(doublereal A, doublereal b, doublereal E);
 
     //! Constructor based on AnyMap content