-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
un-anchored :hover issue #387
base: master
Are you sure you want to change the base?
Conversation
This is an extension of work carried out by hpbuniat. The rule he submitted did not work if there was a null before :hover. This rule tests for the IE7/IE8 issue where un-anchored hovers cause poor performance
Test case
This looks good, can you add documentation on the wiki in the rules section? |
Hi, Would you like me to also make the same updates to with wiki in stubbornella / csslint? |
Yes, please. I like this rule. Let's try to get it into the next version. On Thu, Jun 6, 2013 at 1:57 AM, niallmur [email protected] wrote:
|
id: "non-link-hover", | ||
name: "Non-Link Hover", | ||
desc: "Using :hover pseudo-selector to non-link elements is known to be slow.", | ||
browsers: "IE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be IE7, IE8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated affected browsers to IE7, IE8
Overall, this looks great, just a couple things to clean up. Thanks! |
Updated comments and affected browsers
Hi Nicole, I have made all the changes you asked for. I have however managed to kick off a merge to 'duplicate property value Thanks Niall On Wed, Jun 12, 2013 at 8:12 AM, Nicole Sullivan
|
…this is against convention this is still valid css and wll prevent the :hover performance issue
Can you clean up the branch? Rebase, squash etc. |
This is an extension to work already carried out by hpbuniat.
#116
However the rule he submitted did not work correctly and threw parser errors when there was a null before :hover
This basic check below threw a cant read a null from text error.
div.test :hover{
}
This rule is important because it can cause very severe performance issues in IE7 if :hover is used and un-anchored.
(bug report about un-anchored hovers in IE7 and IE8)
https://developers.google.com/speed/docs/best-practices/rendering
http://msdn.microsoft.com/en-us/library/ie/cc848866%28v=vs.85%29.aspx