Kelly Manahan #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job so far! 👌 |
ckopecky
reviewed
Nov 21, 2018
|
|
||
| { int counter = 0; | ||
| for( int i = 1; i <=n; i++) { | ||
| if (i % 15 == 0) |
There was a problem hiding this comment.
This is fine, but it would be better if the instructions for the program told what to do if it was divisible by 3 and divisible by 5...that way in the grand scheme of things....it's only looking for numbers that are divisible by 3 and 5...not 3, 5 and 15.
if(i % 3 == 0 && i % 5 == 0){
printf("Fizzbuzz \n");
}| @@ -53,7 +60,7 @@ void string_copy(char *x, char *y) | |||
| */ | |||
| int string_compare(char *m, char *n) | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
No code here for string_compare. Other stuff looks good. Try string_compare!
| @@ -35,4 +60,4 @@ int main(void) | |||
|
|
|||
| return 0; | |||
| } | |||
| arr++; | ||
| } | ||
| rv[rvlen] ='\0'; | ||
| return rv; | ||
| } | ||
|
|
||
| #ifndef TESTING |
| free(who -> name); | ||
| } | ||
| free(who); | ||
| } | ||
| } | ||
|
|
||
| #ifndef TESTING |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.