Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prisma for project #36

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add prisma for project #36

merged 2 commits into from
Oct 6, 2023

Conversation

ketphan02
Copy link
Contributor

@ketphan02 ketphan02 commented Oct 4, 2023 •
edited
Loading

Problem

We need to have a ORM - Prisma for the project

Changes

Added Prisma and tested out with the new added docker at #35
Closes #29

@ketphan02 ketphan02 marked this pull request as draft October 4, 2023 18:41
@ketphan02
Copy link
Contributor Author

This requires #35 to be merged

@ketphan02 ketphan02 self-assigned this Oct 4, 2023
@ketphan02 ketphan02 added the setup Project setup task label Oct 4, 2023
@ketphan02 ketphan02 marked this pull request as ready for review October 6, 2023 01:05
@ketphan02 ketphan02 mentioned this pull request Oct 6, 2023
Merged
justino599
justino599 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. From what I gather, this PR provides no visible changes, correct?

@ketphan02
Copy link
Contributor Author

@justino599 Exactly, the visible changes will be at #41

@justino599
Copy link
Contributor

Sounds good, taking a look at that rn

SecondFeline
SecondFeline approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@SecondFeline SecondFeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ketphan02 ketphan02 merged commit c1062ea into master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SecondFeline SecondFeline SecondFeline approved these changes

@justino599 justino599 justino599 approved these changes

@te-sa te-sa Awaiting requested review from te-sa

@Hedgemon4 Hedgemon4 Awaiting requested review from Hedgemon4

Assignees

@ketphan02 ketphan02

Labels
setup Project setup task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Prisma to Project
3 participants
@ketphan02 @justino599 @SecondFeline