Write restart at end of run via NUOPC component attribute & Initialize cpl_scalar field when created for UFS #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add end of run restart file functionality * Add CICE write_restart_at_endofrun config option call * Update cice_wrapper_mod.F90
NickSzapiro-NOAA
changed the title
|
Thanks @NickSzapiro-NOAA - I didn't test but the code looks good. Is supoprt for |
dabail10
approved these changes
Aug 14, 2024
|
Does the namelist flag |
|
@eclare108213 I don't think there is an issue w/ |
|
Ok, as you wish! |
NickSzapiro-NOAA
added a commit
to NOAA-EMC/CICE
that referenced
this pull request
Sep 25, 2024
…e cpl_scalar field when created for UFS (CICE-Consortium#969) These are two commits cherry-picked from as in UFS and needed to close #84. This PR adds the ability for CICE to write restart files at the end of the run (independent of other settings) and controlled via the CMEPS configuration option write_restart_at_endofrun. Setting this configuration option to True creates a restart file in the same way for CMEPS, MOM6, and CICE. This PR also initializes the scalar field value for the index for NTile (implemented for FV3) not used or set in CICE. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). This is the cause of the failure reported in ufs-community/ufs-weather-model#2338. * Add end of run functionality to CICE (#77) * initialize cpl_scalar field when created (#83) --------- Co-authored-by: Daniel Sarmiento <[email protected]> Co-authored-by: Denise Worthen <[email protected]>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Write restart at end of run via NUOPC attribute. Initialize cpl_scalar field when created
Daniel Sarmiento & Denise Worthen
Tested in UFS. See Add end of run functionality to CICE NOAA-EMC/CICE#77 and initialize cpl_scalar field when created NOAA-EMC/CICE#83, respectively
These are two commits cherry-picked from as in UFS and needed to close NOAA-EMC#84.
This PR adds the ability for CICE to write restart files at the end of the run (independent of other settings) and controlled via the CMEPS configuration option write_restart_at_endofrun. Setting this configuration option to True creates a restart file in the same way for CMEPS, MOM6, and CICE.
This PR also initializes the scalar field value for the index for
NTile(implemented for FV3) not used or set in CICE. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). This is the cause of the failure reported in ufs-community/ufs-weather-model#2338.