linenoise update #2307
Open
linenoise update #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| full_path = malloc((int)(ptr - hint) + FILENAME_MAX + 1); | ||
| ++ptr; | ||
| sprintf(full_path, "%.*s", (int)(ptr - hint), hint); |
Check failure
Code scanning / CodeQL
Unbounded write Critical
There was a problem hiding this comment.
Seems like a false-positive to me.
| if (fp == NULL) return -1; | ||
| chmod(filename,S_IRUSR|S_IWUSR); |
Check failure
Code scanning / CodeQL
Time-of-check time-of-use filesystem race condition High
There was a problem hiding this comment.
Seems like a false-positive to me.
lePici
force-pushed
the
linenoise
branch
2 times, most recently
from
f586fc1
to
c5d05b8
Compare
The linenoise source code has been updated to commit d895173 from antirez/linenoise repository. So when you use the diff tool, you'll see bugfixes and customizations for yanglint needs.
The source code of linenoise was modified according to a fork from the yhirose/linenoise repository, commit b35616d.
lePici
force-pushed
the
linenoise
branch
2 times, most recently
from
c292a7f
to
8dbd8f9
Compare
Had to add a new 'cli' command to yanglint in interactive mode. Although the Multiline is more suitable for interactive mode, it creates a problem for tcl tests because it often adds ANSI escape codes. So at the beginning of the tcl tests, multiline is turned off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect alerts from Coverity Scan for
linenoise.corutf-8.c