Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibcirculation: escape user_info #188

Open
wants to merge 101 commits into
base: prod
Choose a base branch
from

Conversation

mvesper
Copy link

@mvesper mvesper commented Sep 15, 2016

  • In some HTML templates, the user info is stored inside an option
    tag. The HTML is created surrounded by single quotes, therefore
    user_info containing a single quote could break it.

ludmilamarian and others added 30 commits November 4, 2015 13:35
* FIX Fixes the order of search results when computing the
  next and previous search links on the record page by not
  reversing the initial search results.

Signed-off-by: Ludmila Marian <[email protected]>
* NEW Record recommender loads and displays recommendations on
  each record page. The recommendations are calculated with the speared
  python package the invenio-record-recommender.

* Loads the calculated recommendations from Redis.

* Creates /record/*id*/recommendations endpoint.

* Introduces CFG_RECOMMENDER_REDIS and CFG_RECOMMENDER_PREFIX config
  used to set the Redis instance from where the recommendations should
  be loaded.

* Renders recommended records in JavaScript after the record is loaded.

* Logs clicks on recommended records to webstat.

Signed-off-by: David Zerulla <[email protected]>
* Makes test suite independent from PDF extraction process.
  (closes inveniosoftware#1590)

* Simplifies test suite.

Signed-off-by: Patrick Glauner <[email protected]>
…ncho/1590-fix-regresion-test-solrutils

  SolrUtils: reliable regression test suite
 * Adds checkbox to search terms also in to fulltext to the add
   to search interface.

Signed-off-by: Patrick Glauner <[email protected]>
 * Ranks fulltext and metadata properly

Signed-off-by: Patrick Glauner <[email protected]>
 * Ceils ranking scores to avoid anomalies

Signed-off-by: Patrick Glauner <[email protected]>
…ncho/master-fulltext-by-default

  Solrutils: more accurate ranking scores
  BibRank: Solr: better ranking for fulltext by default
  WebSearch: new fulltext by default search
* Filters a record based on MARC code.

* Supports wildcards in identifiers and subfield code.

Signed-off-by: Patrick Glauner <[email protected]>
* Supports filtering per MARC tag, identifier and subfield.

Signed-off-by: Patrick Glauner <[email protected]>
…ncho/master-xm-field

  BibFormat: new 'xmf' format
  BibRecord: new MARC code filter
…lamarian/master-weblayout-cds

  WebStyle: add CERN specific URL handlers

Conflicts:
	modules/webstyle/lib/webinterface_layout.py
  BibEncode: Video: Push video to youtube

Conflicts:
	modules/webstyle/css/Makefile.am
	modules/webstyle/lib/webinterface_layout.py
* Added disabled-by-default config options for Elasticsearch logging.

* When Elasticsearch logging is configured, don't populate rnkPAGEVIEWS and
  rnkDOWNLOADS.

Signed-off-by: Joe MacMahon <[email protected]>
…ncho/elasticsearch_logging

  stats: Elasticsearch logging with Lumberjack.
* Adds `loanrequest` schema for `Lumberjack`.

* Adds custom events elastic search logging.

Signed-off-by: Harris Tzovanakis <[email protected]>
  WebStat: register custom events on es
* Back ports lazy dictionaries from next.

Signed-off-by: Esteban J. G. Gabancho <[email protected]>
Signed-off-by: Esteban J. G. Gabancho <[email protected]>
Signed-off-by: Esteban J. G. Gabancho <[email protected]>
Signed-off-by: Esteban J. G. Gabancho <[email protected]>
…ncho/master-backport-pidstore

  BibFormat: DataCite3 export addition
  pidstore: initial release backport
  xmlDict: initial release backport
  containerutils: new lazy data structures
…owski/1918-forbidden-characters-fix

  BibDocFile: disallow percent in filenames
…ilamarian/master-bibconvert-arxiv-license

  BibConvert: retrieve arXiv license information

Conflicts:
	modules/bibconvert/etc/oaiarxiv2marcxml.xsl
…ilamarian/master-bibedit-fix-recid

  BibEdit: fix recID type
…ancho/master-bibfield-bug-fixes

  BibField: bug fixes
…y-missing

  BibReformat: new --only-missing option
…oumis/legacy-webcomment-improvements

  WebComment: cosmetic updates
  WebComment: `collapse` and `expand` all comments
  WebComment: fix collapse and review issues
  WebComment: Enable a custom  checkbox for comments
  WebComment: display comment submission deadline
  WebComment: bibdoc relations & filtering
  WebComment: general comment format improvements

Conflicts:
	Makefile.am
	modules/webcomment/lib/webcomment.py
	modules/webstyle/css/invenio.css
	modules/webstyle/img/Makefile.am
	requirements.txt
* Moves page "Your Searches" from WebAlert to WebSearch and
  under the /yoursearches/ URL. Updates all the respective URLs
  and function calls. Moves function account_list_searches()
  from WebAlert to WebSearch.

* Separates the popular alerts page from the user searches page
  and creates new separate function for popular alerts the user
  can choose from to set up new alerts.

* Fixes various doc strings, variable and function names.

  (closes inveniosoftware#880)
egabancho and others added 26 commits May 9, 2016 18:19
…_mm_cds

  WebHelp: new multimedia help page for CDS
…sorting_washer

  BibSort: new washer for journal number
* Adds a new predefined keyword for year generation.

Co-Authored-By: Ludmila Marian <[email protected]>
Signed-off-by: Ludmila Marian <[email protected]>
…er_generation-enhancements

  WebSubmit: report number generation enhacement
…er_view_restr

  WebAccess: improve viewer rights access
…search_latest

  WebSearch: consider sort order when searching
* Adds `CFG_ELASTICSEARCH_FALLBACK_DIRECTORY` configuration variable
  to specify where the fallback file to be stored.

* Creates a fallback file with the hostname as file name.

Signed-off-by: Harris Tzovanakis <[email protected]>
…fallback

  elasticsearch: fallback file per hostname
* IMPROVEMENT Adds `downloads` and `pagesviews` as custom events.

* Custom events will be registered only in elasticsearch if
  `CFG_ELASTICSEARCH_LOGGING` is enabled.

Signed-off-by: Harris Tzovanakis <[email protected]>
…-option

  webstat: downloads and pageviews as events
* A ILL is currently extended by manually updating the *due_date* of
  that ILL, this leads to the following issue:
  A user receives an ILL recall letter, therefore gets the ILL extended
  at the library.
  The next ILL recall letter will be of the second category, since the
  *overdue_letter_number* never gets reseted.

* Introduces the new function *update_ill_request_letter_number*

* Changes the *overdue_letter_number* in case the updated due_date is a
  later date than the current due_date in
  *ill_request_details_step2*.

Signed-off-by: Martin Vesper <[email protected]>
…per/invenio_ill_recall_mail

  BibCirculation: reset ILL overdue_letter_number

  Notes:
    Update accordingly to Tibor's comments in inveniosoftware#3592
…e/legacy-obelix-pr

  WebSearch: optional Obelix integration

Conflicts:
	modules/miscutil/lib/Makefile.am
	modules/websearch/lib/websearch_webinterface.py
	requirements.txt
* Fixes creation of the Invenio config with the tool inveniocfg.
  The `elasticsearch_logging` module tries to use the invenio.config
  before the config is created. To reproduce remove the invenio.config
  and run `inveniocfg --update-all`.

Signed-off-by: David Zerulla <[email protected]>
…e/legacy-record-recommender

  BibFormat: optional record recommender

Conflicts:
	config/invenio.conf
	modules/miscutil/lib/Makefile.am
	modules/websearch/lib/websearch_webinterface.py
	modules/webstyle/css/invenio.css
* FFT__y subfield contains language for files uploaded to the
  committee documents collections.

Signed-off-by: Sebastian Witowski <[email protected]>
* If CFG_CERN_SITE, consider the possibility of the viewer
  of a record being an egroup, defined as '[email protected]'
  insted of 'foo [CERN]'.

Signed-off-by: Ludmila Marian <[email protected]>
…_record_viewer

WebSearch: improve detection of record viewers
…prev_next_order

Legacy fix prev next order
…button-disable

websubmit: disable submit button correction
…t-remove-request

BibEdit: remove request from multiedit search
…t-articles-from-deleted-categories

WebJournal: redirect articles addition
…webjournal_index_page

Legacy fix webjournal index page
…ntis-update

Bibfield: Add y subfield to FFT
* In some HTML templates, the user info is stored inside an option
  tag. The HTML is created surrounded by single quotes, therefore
  user_info containing a single quote could break it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants