Misc Improvements #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works much better with Material themes Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Get rid of wildcard imports otherwise ktlint complains about it Signed-off-by: Aayush Gupta <[email protected]>
Also move it to a new package Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
fdff87554
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
This optimization greatly increases the code's readability and the maintenance's convenience. Still, it also adds a package that requires at least Android 13 or above and abandons some version checks (cancels maintenance for Android 5 and below), which helps to simplify subsequent maintenance costs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does minor misc improvements as the commit message states.
Test
Build and run on a real device.