Skip to content

Commit

Permalink
avoid Cargo.lock in exported archives (#253)
Browse files Browse the repository at this point in the history 
That way, it's more likely downloaded source archives compile.

This comes at a trade-off though as it's nice to document what was working
as well, and it's easy to run `cargo update`.
  • Loading branch information
@Byron
Byron committed Aug 5, 2024
1 parent 319bdde commit 2ef583d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitattributes
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Cargo.lock export-ignore

4 comments on commit 2ef583d

@alerque
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong and should be reverted. It might have been a temporary stand by to patch over a bad deal with the last release, but you've now broken offline builds and reproducability for future versions. v2.29.1 can't be packaged properly on Arch Linux now

@Byron
Copy link
Owner Author

@Byron Byron commented on 2ef583d Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's reverted now, and I think Arch Linux can skip this one anyway as it's not containing user-facing features.

@alerque
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting.

And I understand what you're saying about we could skip the release but pragmatically that doesn't work. Our automated tooling shows it up in a list of outdated packages (based on nvchecker seeing the upstream tags) and users keep manually flagging it as out of date. Just dismissing and replying to the out of date flags to say the release is irrelevant to Arch is more work that just bumping the package!

@Byron
Copy link
Owner Author

@Byron Byron commented on 2ef583d Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making me aware.

Meantime, a new release was created to get Cargo.lock back: https://github.com/Byron/dua-cli/releases/tag/v2.29.2 .

Please sign in to comment.