Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable proxy buffering for calls to OIDC endpoints #15015

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

shogunpurple
Copy link
Member

Description

Sometimes OIDC responses are very heavy - lots of headers and big response bodies. This was causing an issue in our NGINX layer for MSFT AD.

Copy link

qa-wolf bot commented Nov 16, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@calexiou calexiou marked this pull request as ready for review November 16, 2024 14:52
@calexiou calexiou self-requested a review November 16, 2024 14:53
Copy link
Contributor

@calexiou calexiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shogunpurple shogunpurple merged commit 5a4af89 into master Nov 16, 2024
13 checks passed
@shogunpurple shogunpurple deleted the oidc-proxy-buffering branch November 16, 2024 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants